Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: add MSan task for Rust #325

Closed
wants to merge 2 commits into from
Closed

circleci: add MSan task for Rust #325

wants to merge 2 commits into from

Conversation

axic
Copy link
Member

@axic axic commented Jun 19, 2019

No description provided.

@axic axic added this to In progress in v6.3 via automation Jun 19, 2019
@axic axic force-pushed the rust-msan branch 2 times, most recently from 7dc6b6c to 5842864 Compare June 19, 2019 19:25
@chfast
Copy link
Collaborator

chfast commented Jun 25, 2019

I have some questions:

  1. What kind of errors do you want to find with it and in what code?
  2. MemorySanitizer is a subset of Valgrind Memcheck. The later would be much easier to use.

@axic
Copy link
Member Author

axic commented Jun 25, 2019

Well it already found an issue. We have already merge ASan support which also discovered some problems in the Rust FFI parts. We are handling memory in an unsafe manner, hence it is useful to enforce these checks.

@chfast
Copy link
Collaborator

chfast commented Jun 25, 2019

Well it already found an issue.

Did MSan find any issue? It was never useful for me.

apt-key adv --keyserver keyserver.ubuntu.com --no-tty --recv-keys 6084F3CF814B57C1CF12EFD515CF4D18AF4F7421 60C317803A41BA51845E371A1E9377A2BA9EF27F
apt -qq update
apt -yq install llvm-8-dev clang-8
rustup toolchain install nightly-x86_64-unknown-linux-gnu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to update rust if you use a docker image?

Copy link
Member Author

@axic axic Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about installing nightly, it is not available by default. Note, it is also done in the asan case (already merged).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know. It would be good to make a custom image with LLVM and rust nightly or run different configuration builds as a sequence of steps, not independent jobs.

@axic
Copy link
Member Author

axic commented Jun 25, 2019

Well it already found an issue.

Did MSan find any issue? It was never useful for me.

Check out the log for bindings-rust-msan. It is not fixed yet.

@chfast
Copy link
Collaborator

chfast commented Jun 25, 2019

Check out the log for bindings-rust-msan.

I stopped at build warnings previously.

@axic
Copy link
Member Author

axic commented Jun 25, 2019

Check out the log for bindings-rust-msan.

I stopped at build warnings previously.

There are no build warnings.

@chfast
Copy link
Collaborator

chfast commented Jun 25, 2019

Check out the log for bindings-rust-msan.

I stopped at build warnings previously.

There are no build warnings.

   Compiling example-rust-vm v0.1.0 (/root/project/examples/example-rust-vm)
warning: unused variable: `code`
  --> bindings/rust/evmc-declare-tests/src/lib.rs:22:23
   |
22 |     fn execute(&self, code: &[u8], context: &ExecutionContext) -> ExecutionResult {
   |                       ^^^^ help: consider prefixing with an underscore: `_code`

@axic
Copy link
Member Author

axic commented Jun 25, 2019

Okay, you can ignore them, those are style warnings in tests.

@axic axic force-pushed the rust-msan branch 3 times, most recently from 707ef62 to 07c51fc Compare June 27, 2019 12:24
@axic axic removed this from In progress in v6.3 Jul 8, 2019
@axic axic force-pushed the rust-msan branch 2 times, most recently from 2a46b76 to 6f8a24a Compare August 11, 2019 09:01
@chfast chfast added this to In progress in v7.0 via automation Sep 19, 2019
@axic axic added this to In progress in v8.0 via automation Nov 4, 2019
@axic axic removed this from In progress in v7.0 Nov 4, 2019
@axic axic closed this Nov 27, 2019
v8.0 automation moved this from In progress to Done Nov 27, 2019
@axic axic deleted the rust-msan branch November 27, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v8.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants