New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circleci: add MSan task for Rust #325
Conversation
7dc6b6c
to
5842864
Compare
I have some questions:
|
Well it already found an issue. We have already merge ASan support which also discovered some problems in the Rust FFI parts. We are handling memory in an unsafe manner, hence it is useful to enforce these checks. |
Did MSan find any issue? It was never useful for me. |
apt-key adv --keyserver keyserver.ubuntu.com --no-tty --recv-keys 6084F3CF814B57C1CF12EFD515CF4D18AF4F7421 60C317803A41BA51845E371A1E9377A2BA9EF27F | ||
apt -qq update | ||
apt -yq install llvm-8-dev clang-8 | ||
rustup toolchain install nightly-x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to update rust if you use a docker image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about installing nightly, it is not available by default. Note, it is also done in the asan case (already merged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know. It would be good to make a custom image with LLVM and rust nightly or run different configuration builds as a sequence of steps, not independent jobs.
Check out the log for |
I stopped at build warnings previously. |
There are no build warnings. |
|
Okay, you can ignore them, those are style warnings in tests. |
707ef62
to
07c51fc
Compare
2a46b76
to
6f8a24a
Compare
No description provided.