go: Add missing Shanghai revision constant #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 24 24
Lines 3971 3971
=======================================
Hits 3801 3801
Misses 170 170 |
axic
reviewed
Jun 29, 2021
bindings/go/evmc/evmc.go
Outdated
| @@ -149,6 +149,8 @@ const ( | |||
| Istanbul Revision = C.EVMC_ISTANBUL | |||
| Berlin Revision = C.EVMC_BERLIN | |||
| London Revision = C.EVMC_LONDON | |||
| Shanghai Revision = C.EVMC_SHANGHAI | |||
| maxRevision Revision = C.EVMC_MAX_REVISION | |||
There was a problem hiding this comment.
maxRevision is private and cannot be used outside of the evmc package.
There was a problem hiding this comment.
How is it private? Because lowercase?
There was a problem hiding this comment.
Yes. But made it public now together with LatestStableRevision. I don't want to overthink it.
axic
reviewed
Jun 29, 2021
| @@ -149,6 +149,8 @@ const ( | |||
| Istanbul Revision = C.EVMC_ISTANBUL | |||
| Berlin Revision = C.EVMC_BERLIN | |||
| London Revision = C.EVMC_LONDON | |||
| Shanghai Revision = C.EVMC_SHANGHAI | |||
| maxRevision Revision = C.EVMC_MAX_REVISION | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Unrelated, but can't comment on the line: can func (err Error) Error() string be replaced by the new string helpers?
axic
reviewed
Jun 29, 2021
bindings/go/evmc/evmc_test.go
Outdated
| @@ -59,3 +59,9 @@ func TestExecuteEmptyCode(t *testing.T) { | |||
| t.Errorf("execution returned unexpected error: %v", err) | |||
| } | |||
| } | |||
|
|
|||
| func TestRevision(t *testing.T) { | |||
| if MaxRevision != London { | |||
There was a problem hiding this comment.
Should there also be a test for LatestStableRevision here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that fails in case of
C.EVMC_MAX_REVISIONis increased as a remainder to add new Revision constants to Go.The missing London Revision is added.