Implement EIP-7610 (non-empty storage create collision) and upgrade execution-tests #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 98.50% 98.28% -0.23%
==========================================
Files 130 127 -3
Lines 15619 15574 -45
==========================================
- Hits 15386 15307 -79
- Misses 233 267 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
state/eip_7610_create_collision
branch
3 times, most recently
from
6dd6bd6
to
af793ec
Compare
chfast
changed the title
chfast
force-pushed
the
state/eip_7610_create_collision
branch
from
333d376
to
858f717
Compare
chfast
force-pushed
the
state/create_refactor
branch
from
42e86ea
to
9fbb408
Compare
chfast
force-pushed
the
state/eip_7610_create_collision
branch
from
858f717
to
de11a0e
Compare
chfast
force-pushed
the
state/eip_7610_create_collision
branch
from
de11a0e
to
936bba3
Compare
chfast
changed the title
chfast
commented
May 6, 2024
| @@ -268,14 +275,6 @@ evmc::Result Host::create(const evmc_message& msg) noexcept | |||
|
|
|||
| new_acc->just_created = true; | |||
|
|
|||
| // Clear the new account storage, but keep the access status (from tx access list). | |||
| // This is only needed for tests and cannot happen in real networks. | |||
| for (auto& [k, v] : new_acc->storage) [[unlikely]] | |||
There was a problem hiding this comment.
Because the storage is empty now we don't have to do anything with it. This is really nice because this eliminates the only case for storage traversal in EVM.
There was a problem hiding this comment.
could replace with assertion, but not very important
There was a problem hiding this comment.
Not easy check because of the access list... so I'll pass.
gumb0
reviewed
May 7, 2024
gumb0
reviewed
May 7, 2024
gumb0
approved these changes
May 7, 2024
This implements EIP-7610: Revert creation in case of non-empty storage. When a contract creation collides with an existing account it also reverts in case of the storage not being empty. https://eips.ethereum.org/EIPS/eip-7610
Also disable EIP tests for EIP-2537 because this is not implemented.
chfast
force-pushed
the
state/eip_7610_create_collision
branch
from
9720138
to
f538f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements EIP-7610: Revert creation in case of non-empty storage.
When a contract creation collides with an existing account it also reverts in case of the storage not being empty.
The ethereum/tests are upgraded to v13.3.