Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API: refine message ordering section #133

Merged
merged 4 commits into from Nov 29, 2021

Conversation

mkalinin
Copy link
Collaborator

Refines the Message ordering section of the Engine API.

The previous version of the spec had the following overlooks:

  • CL could flip two forkchoiceUpdated messages before the IDs were assigned which could result in inconsistency of the head of the chain between the layers
  • The restrictions on EL side were too strong. EL couldn't process two different messages in parallel which e.g. locks the client until executePayload processing is finished

Proposed changes:

  • CL: add the requirement to respect the order of occurrence of fork choice updated event
  • EL: restrict enforcement of processing order to forkchoiceUpdated calls only

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, but generally LGTM.

src/engine/specification.md Show resolved Hide resolved
src/engine/specification.md Show resolved Hide resolved
src/engine/specification.md Show resolved Hide resolved
@ethereum ethereum deleted a comment from kenyahewitt Nov 29, 2021
src/engine/specification.md Outdated Show resolved Hide resolved
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
src/engine/specification.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants