Engine API: Refine message ordering. Take 2 #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Message ordering mechanism based on request IDs. JSON-RPC request IDs might be difficult to get parsed depending on the JSON-RPC library. The new proposal doesn't rely on request IDs at all and removes the logic that is required to reset this ID, which in its turn introduces inconvenience for setups with multiple EL clients behind a load balancer.
The proposed approach doesn't require CL client software to send
forkchoiceUpdated
calls in a lock-step fashion. But it's based on the assumption that the underlying protocol doesn't mess up with the order of messages, i.e. if CL sends the following sequence of calls:[fcU(A), fcU(B)]
then EL client will always receivefcU(A)
beforefcU(B)
. This assumption gets broken if HTTP over multiple TCP sessions is used as the underlying communication protocol.