Engine API: employ one method one structure approach for V3 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
g11tech
approved these changes
Jun 8, 2023
8 tasks
|
Thanks |
|
Well done |
1 similar comment
|
Well done |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switched
V3methods to one method - one structure approach that we have agreed upon in the recent ACDC.This PR enforces EL client to check that parameters and their fields in
newPayloadV3aren'tnulland makes the client to respond with error otherwise. Also, a similar validation is applied to thetimestampbeing greater or equal to 4844 activation. This enforcement can protect us from bugs like when CL attempts to send an old payload structure and EL accepts it. Happy to hear more inputs on that.EDIT: A new
-38005: Unsupported forkerror is introduced to surface the case when a payload is from a fork that is not supported by a method e.g. Shanghai payload is submitted vianewPayloadV3which minimal supported fork is Cancun.