Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: add eth_fillTransaction, fix result of eth_signTransaction #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 16, 2024

Fixes #508

While adding spec for eth_fillTransaction I noticed that the spec for eth_signTransaction deviates from the geth implementation. I'm not sure yet how other clients implement this.

@s1na
Copy link
Contributor Author

s1na commented Feb 10, 2024

I've updated the PR with support for generation and verification of blob sidecars. The proposal is as follows:

If the transaction arguments contain a non-empty list of blobs, then, fillTransaction will:

  • Fill in proofs, commitments if they are not provided
  • Verify proofs, commitments if they are provided

And later verify or compute blob hashes from those commitments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eth_fillTransaction
1 participant