engine: Extend payload bodies with deposit and withdrawal requests #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
approved these changes
May 12, 2024
terencechain
approved these changes
May 14, 2024
|
Was talking to @mkalinin about this today. Looks like both V1 and V2 are backwards compatible and we won't want to deal with switching endpoints at the fork since they might be used during syncing for example. It probably makes sense to just extend V1. |
|
prysm implemented v2 but not that big of a deal to go back if there's consensus on that |
11 tasks
I agree, I think it will be better to extend V1. We added V2 methods for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
ExecutionPayloadBodyV2to accommodatedepositRequestsandwithdrawalRequestsadded to the payload body in Prague, this entails adding newengine_getPayloadBodiesByRangeV2andengine_getPayloadBodiesByHashV2methods. This PR also contains a few naming adjustments in the examples part of the schema.