Engine API: expose eth namespace to reduce to single connection #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to single connection
lightclient
approved these changes
Nov 2, 2021
mkalinin
reviewed
Nov 2, 2021
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
djrtwo
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently beacon-nodes use the
ethnamespace to read state and event-logs, to track beacon-chain deposits (see deposit contract consensus specs), as well as "eth1-data-votes" (legacy, but this voting process will still be present in the merge, until later cleanup fork).During the merge-interop event I think @holiman (iirc?) proposed to expose the
ethnamespace under this same new secured engine-specific port, so beacon-nodes do not have to open two different connections to the same execution node.All execution-layer clients already support these namespaces as "modules" of some kind, and this modularity means the
ethnamespace can be exposed on this endpoint with minimal changes in the EL, and reduces changes on the CL (would otherwise need to support two different connections for engine and deposits work).Assuming this reduction in setup complexity/work is desired, I am not sure if it should be a
MAYorMUSTin the spec. Is there any case where we do not like to exposeethunder this endpoint?