Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output.body/txs rlp support for ethereum-spec-evm #268

Closed
danceratopz opened this issue Aug 23, 2023 · 1 comment
Closed

Add output.body/txs rlp support for ethereum-spec-evm #268

danceratopz opened this issue Aug 23, 2023 · 1 comment
Labels
scope:evm Scope: evm_transition_tool package type:bug Something isn't working

Comments

@danceratopz
Copy link
Member

danceratopz commented Aug 23, 2023 •
edited

This is likely an issue with the ethereum-spec-evm t8n tool; this is a reminder to double-check this and re-enable when solved.

Specifying --output.body=stdout doesn't write the body to stdout, but rather to a file called "stdout" in the directory specified by --output.basedir.

As of #269, a temporary output directory for --output.basedir is no longer specified if tracing is not enabled (it's not required for geth/nimbus); previously this would have worked as the "stdout" file would have been written here and subsequently copied.
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this issue Aug 23, 2023
@danceratopz
tools: don't write output.body for ethereum-specs-evm cf ethereum#268
7cbefd4
This was referenced Aug 24, 2023
Merged
Merged
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this issue Aug 24, 2023
@danceratopz
tools: don't write output.body for ethereum-specs-evm cf ethereum#268
32ac3bf
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this issue Aug 29, 2023
@danceratopz
Revert "tools: don't write output.body for ethereum-specs-evm cf ethe…
504b7e4 
…reum#268"

This reverts commit 32ac3bf.
@danceratopz danceratopz added type:bug Something isn't working scope:evm Scope: evm_transition_tool package labels Sep 26, 2023
@danceratopz
Copy link
Member Author

Fixed by ethereum/execution-specs#823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:evm Scope: evm_transition_tool package type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danceratopz