Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture Format: Add transactions/uncleHeaders/withdrawals for BlockchainTests #56

Closed
spencer-tb opened this issue Jan 30, 2023 · 2 comments
Closed

Fixture Format: Add transactions/uncleHeaders/withdrawals for BlockchainTests #56

spencer-tb opened this issue Jan 30, 2023 · 2 comments
Assignees
@spencer-tb

Comments

@spencer-tb
Copy link
Collaborator

Add the following fields for BlockchainTests. Omit the withdrawals field unless >= Shanghai fork. WIP: PR #47

image
@spencer-tb spencer-tb self-assigned this Jan 30, 2023
@winsvega
Copy link
Collaborator

winsvega commented Jan 31, 2023 •
edited
Loading

chainname is optional and deprecated. it was used for multichain blockchain tests where chain reorg happen due to total difficulty. it is a debug field for user to read. not needed anymore as it is only one chain now.

withdrawals only present for ShanghaiBlocks.

By default if no transactions or no uncles. the fields are set to empty. and exported anyway

@spencer-tb spencer-tb changed the title Fixture Format: Add chainname/transactions/uncleHeaders/withdrawals for BlockchainTests Fixture Format: Add transactions/uncleHeaders/withdrawals for BlockchainTests Jan 31, 2023
@spencer-tb
Copy link
Collaborator Author

Closing after merging: #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencer-tb spencer-tb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winsvega @spencer-tb