Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update existing fixture test format to export correct schema #47

Merged
merged 17 commits into from
Feb 6, 2023
Merged

Update existing fixture test format to export correct schema #47

merged 17 commits into from
Feb 6, 2023

Conversation

spencer-tb
Copy link
Collaborator

This PR addresses the 2 issues regarding the exported fixture json format: #39 #38

@spencer-tb
Copy link
Collaborator Author

Here is an example of the updated format for the accounts:

image

Compared to the old format:

image

@spencer-tb spencer-tb marked this pull request as ready for review January 26, 2023 16:16
@spencer-tb
Copy link
Collaborator Author

spencer-tb commented Jan 28, 2023 •
edited
Loading

The refactored function even_padding() can re-format any Dict. Waiting to find out what fields need to be excluded from re-formating.

@spencer-tb spencer-tb mentioned this pull request Jan 30, 2023
Closed
marioevz
marioevz requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I have a few comments!

src/ethereum_test_tools/common/types.py Outdated Show resolved Hide resolved
src/ethereum_test_tools/common/types.py Outdated Show resolved Hide resolved
src/ethereum_test_tools/common/types.py Outdated Show resolved Hide resolved
@spencer-tb spencer-tb changed the title Update existing fixture test format to export correct schema WIP: Update existing fixture test format to export correct schema Jan 30, 2023
marioevz
marioevz reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the new code.

src/ethereum_test_tools/common/types.py Outdated Show resolved Hide resolved
src/ethereum_test_tools/common/types.py Outdated Show resolved Hide resolved
marioevz
marioevz approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marioevz marioevz changed the title WIP: Update existing fixture test format to export correct schema Update existing fixture test format to export correct schema Feb 6, 2023
@marioevz marioevz merged commit f306d8e into ethereum:main Feb 6, 2023
@spencer-tb spencer-tb deleted the test-format-spec branch February 6, 2023 19:43
This was referenced Feb 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencer-tb @marioevz