Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): enable tracing support for ethereum-spec-evm #289

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Sep 6, 2023

ethereum/execution-specs#828 implements full tracing for ethereum-spec-evm. This PR simply removes the exception so that tracing with the execution-specs t8n tool can be enabled within execution-spec-tests.

We should hold off merging this PR until ethereum/execution-specs#828 is merged.

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we really need a t8n spec don't we? Will be really nice once everything is in the same format etc

@danceratopz
Copy link
Member Author

LGTM - we really need a t8n spec don't we? Will be really nice once everything is in the same format etc

Thanks @spencer-tb. The tracing in ethereum-spec-evm is implemented according to https://eips.ethereum.org/EIPS/eip-3155 and matches well with geth's! (It's just the filename and lack of multi-txn support missing).

But yes, a broader t8n spec would be great.

@spencer-tb
Copy link
Collaborator

Looks like we can merge now :D

@danceratopz danceratopz added scope:evm Scope: evm_transition_tool package type:feat type: Feature labels Sep 27, 2023
@danceratopz danceratopz force-pushed the tools/add-tracing-to-ethereum-spec-evm branch from 823cfeb to 98c3075 Compare September 27, 2023 05:10
@danceratopz danceratopz changed the title tools: allow tracing support with ethereum-spec-evm feat(evm): enable tracing support for ethereum-spec-evm Sep 27, 2023
@danceratopz danceratopz merged commit 29fa3f4 into ethereum:main Sep 27, 2023
5 checks passed
@danceratopz danceratopz deleted the tools/add-tracing-to-ethereum-spec-evm branch September 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:evm Scope: evm_transition_tool package type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants