chore: add python 3.12 support #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
approved these changes
Sep 26, 2023
spencer-tb
added
scope:tools
spencer-tb
added
scope:fw
spencer-tb
force-pushed
the
chore/add-python-3.12-support
branch
from
a35f4fe
to
84d16af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Tested with 3.12.0rc3 built via pyenv.
The same version of flake8 (6.0.0) produced more warnings on Python 3.12 vs 3.10/3.11 (so these are fixed). But, since our flake8 version requirement in setup.cfg didn't make any sense (
flake8>=5,<=6, note the<=6), I bumped this version to ensure we use patches/improvements in v6. Practically as of now, it means we'll use 6.1.0 instead of 6.0.0.✅ Checklist