refactor: Abstract fixture type collection; Parametrize tests over fixture formats; Per-format sub-folder output #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
feat/statetest-fixture-collector
branch
from
f38a6f6
to
d749226
Compare
|
Fixtures for test types are now also generated automatically ( |
|
Ready for review @spencer-tb @danceratopz , let me know what you think! |
danceratopz
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Looks awesome so far, still going through it 🙂.
One suggestion would be marioevz#12.
* feat(pytest): allow filtering by fixture format via pytest mark * feat(fw): give unset fixture format a more verbose name
* feat(pytest): remove items which are pre-merge and have hive format * chore: make exception string clearer; fix whitespace
marioevz
changed the title
marioevz
changed the title
marioevz
added a commit
that referenced
this pull request
Dec 22, 2023
…xture formats; Per-format sub-folder output (#358) * tools: Move fixture collector to spec * refactor: Fixtures collector * all: remove `BaseTestConfig` * fix: all filler tests * docs: update * tox: spelling * feat: Parametrize the supported fixture types for each test type * fix: many tests * fix: remaining tests * fix: fixture name case * fix: Indirect parametrize using fixture format * feat: Dynamic generation of spec test fixtures * fix: type-checking * fix: imports * feat(pytest): allow filtering by fixture format via pytest mark (#12) * feat(pytest): allow filtering by fixture format via pytest mark * feat(fw): give unset fixture format a more verbose name * feat(pytest): only paramatrize post-merge forks with hive format (#13) * feat(pytest): remove items which are pre-merge and have hive format * chore: make exception string clearer; fix whitespace * fix(pytest): test_filler: remove `enable_hive` completely * fix: Remove unused `STATE_TEST_HIVE` --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
marioevz
added a commit
that referenced
this pull request
Jan 6, 2024
…xture formats; Per-format sub-folder output (#358) * tools: Move fixture collector to spec * refactor: Fixtures collector * all: remove `BaseTestConfig` * fix: all filler tests * docs: update * tox: spelling * feat: Parametrize the supported fixture types for each test type * fix: many tests * fix: remaining tests * fix: fixture name case * fix: Indirect parametrize using fixture format * feat: Dynamic generation of spec test fixtures * fix: type-checking * fix: imports * feat(pytest): allow filtering by fixture format via pytest mark (#12) * feat(pytest): allow filtering by fixture format via pytest mark * feat(fw): give unset fixture format a more verbose name * feat(pytest): only paramatrize post-merge forks with hive format (#13) * feat(pytest): remove items which are pre-merge and have hive format * chore: make exception string clearer; fix whitespace * fix(pytest): test_filler: remove `enable_hive` completely * fix: Remove unused `STATE_TEST_HIVE` --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
marioevz
added a commit
that referenced
this pull request
Jan 10, 2024
…xture formats; Per-format sub-folder output (#358) * tools: Move fixture collector to spec * refactor: Fixtures collector * all: remove `BaseTestConfig` * fix: all filler tests * docs: update * tox: spelling * feat: Parametrize the supported fixture types for each test type * fix: many tests * fix: remaining tests * fix: fixture name case * fix: Indirect parametrize using fixture format * feat: Dynamic generation of spec test fixtures * fix: type-checking * fix: imports * feat(pytest): allow filtering by fixture format via pytest mark (#12) * feat(pytest): allow filtering by fixture format via pytest mark * feat(fw): give unset fixture format a more verbose name * feat(pytest): only paramatrize post-merge forks with hive format (#13) * feat(pytest): remove items which are pre-merge and have hive format * chore: make exception string clearer; fix whitespace * fix(pytest): test_filler: remove `enable_hive` completely * fix: Remove unused `STATE_TEST_HIVE` --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Modifies the fixture collector to collect and dump any kind of test (BlockchainTest, StateTest, or TransactionTest).
The fixtures are now dumped in separate subfolders depending on the fixture type.
E.g. BlockchainTest tests are dumped at
fixtures/blockchain_tests, with current test folder output as previously.🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.