Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix minimum balance required on 4844 blob tx gas tests, add contract creation type-3 test #379

Merged
merged 8 commits into from
Jan 15, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 10, 2024

🗒️ Description

Fixes:

  • Gas limit on blob transactions, where the value was hard-coded to 21,000 without taking tx.data into account, or access lists
  • Minimum balance calculation that the account requires for the transaction to be valid
  • Type-3 contract creating transaction test

Adds tests:

  • Prefund the blob tx sender account within the same block using a prepended transaction (block should be valid)
  • Test more combinations of max_fee_per_gas (including value higher than current block base fee)
  • Test blob transactions with access lists

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:test Type: Test labels Jan 10, 2024
@marioevz
Copy link
Member Author

Fixes #376

@marioevz marioevz changed the title fix(tests): Fix minimum balance required on 4844 blob tx gas tests fix(tests): Fix minimum balance required on 4844 blob tx gas tests, add contract creation type-3 test Jan 12, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@marioevz marioevz merged commit 60548f1 into ethereum:main Jan 15, 2024
5 checks passed
@marioevz marioevz deleted the fix-4844-blob-tx-gas-tests branch January 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants