Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): FixtureHeader join (for rlp_modifier) #398

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 24, 2024

🗒️ Description

Small fix to the join method used when a block has an rlp_modifier.

I used this to debug a Besu issue, and I was setting the rlp_modifier = Header(state_root='0x...'), and set the state root to a string, hoping that it would be automatically converted to the appropriate type, but that didn't happen.

With the change in the PR, the state root, and all other fields, are automatically converted to the correct type.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jan 24, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests - it works! 🙂

@marioevz marioevz merged commit ad35812 into ethereum:main Jan 25, 2024
5 checks passed
@marioevz marioevz deleted the fix-header-join branch January 25, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants