Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(fw): fix account empty code check #425

Merged
merged 2 commits into from
Feb 6, 2024
Merged

bug(fw): fix account empty code check #425

merged 2 commits into from
Feb 6, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Feb 6, 2024 •
edited
Loading

🗒️ Description

Fixes empty account check, and fixes account merging so that empty accounts are removed.

🔗 Related Issues

ethereum/execution-specs#871

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels Feb 6, 2024
@marioevz marioevz mentioned this pull request Feb 6, 2024
Closed
spencer-tb
spencer-tb approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

@spencer-tb spencer-tb changed the title fix(fw): Fix account empty code check bug(fw): fix account empty code check Feb 6, 2024
@spencer-tb spencer-tb merged commit ccf25a3 into ethereum:main Feb 6, 2024
5 checks passed
@marioevz marioevz deleted the remove-empty-acct-on-beacon-root-test branch February 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marioevz @spencer-tb