feat(fw): Remove _make_request and replace using it to EthRPC methods

[artemd24]

🗒️ Description

Remove _make_request from RequestManager in cli.gentest.py.
Replace using _make_request to next EthRPC methods: get_block_by_number, get_transaction_by_hash, debug_trace_call.
Add 2 more new methods to EthRPC: get_transaction_by_hash, debug_trace_call.

Extend EthRPC add new methods:

1. get_transaction_by_hash(self, transaction_hash: str)
2. debug_trace_call(self, tr: RequestManager.RemoteTransaction)

🔗 Related Issues

Resolve #561

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.

[artemd24]

Hello @danceratopz,
please verify changes

[danceratopz]

Thanks a lot for getting on this!

Whilst reviewing your code, I realized that gentest is currently broken, so you wouldn't have been able to execute your code. I've addressed this in #576.

It might be worth waiting for #576 to get merged before making heavier changes here, but in the meantime, you can try to get gentest (in the #576 branch) running, for this you'll need access to an archive node. If you don't have one personally, you can get it running using a free endpoint from https://www.portal.grove.city, for example. Check gentest module docstring in #576 for more help.

Otherwise, we use tox to lint and type-check our code in order to enforce our code standards. Some of these are rather pedantic, but are generally very useful. Tox is executed as part of Github but you can run tox locally first to ensure that Github Actions pass. You I fixed up import ordering in 43f5e3f, but we still have a few other issues, which I've noted below. Feel free to ping me for help (danceratopz on telegram/discord, if you get stuck). Here's some help to get started with:

• https://ethereum.github.io/execution-spec-tests/main/writing_tests/code_standards/
• https://ethereum.github.io/execution-spec-tests/main/writing_tests/verifying_changes/

[artemd24]

@danceratopz
Thank you for the detailed comment!
I agree with you to wait until #576 will be merged
however I'm going to add some fixes from your comment, it looks like there are some work that has to be done

[spencer-tb]

Some quick comments on my side! Nice one :D

[danceratopz]

Hey @artemd24, thanks again for this! I'll be afk for a while and didn't want to leave this hanging while away, so I tried this out today and made a few fixes - I hope you don't mind. I tried to split the commits logically, so you can treat them as a review. I also asked @spencer-tb for some quick feedback 🙂.

Feel free to pick up on @spencer-tb's comments and work on any of them them in a new PR! But don't feel obliged!

[artemd24]

@danceratopz @spencer-tb
Thank you very much for helping me! I was a bit stuck and didn't see where to go.
Anyway @danceratopz thank you for your patient and for refactoring I will certainly examine all changes!
Additional thanks to @spencer-tb, your comments are very useful for me in perspective of improvement of my involvement and contribution in opensource