Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a dataclass for apply_body's return value #875

Closed
SamWilsn opened this issue Feb 1, 2024 · 0 comments · Fixed by #933
Closed

Make a dataclass for apply_body's return value #875

SamWilsn opened this issue Feb 1, 2024 · 0 comments · Fixed by #933
Assignees

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Feb 1, 2024

It's getting really unwieldy:

def apply_body(
state: State,
block_hashes: List[Hash32],
coinbase: Address,
block_number: Uint,
base_fee_per_gas: Uint,
block_gas_limit: Uint,
block_time: U256,
block_difficulty: Uint,
transactions: Tuple[Union[LegacyTransaction, Bytes], ...],
ommers: Tuple[Header, ...],
chain_id: U64,
) -> Tuple[Uint, Root, Root, Bloom, State]:

Originally posted by @SamWilsn in #867 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants