Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump required minimum version of coincurve #827

Conversation

danceratopz
Copy link
Member

What was wrong?

ethereum/execution-spec-tests installs the ethereum package provided by execution-specs as a dependency. Both execution-spec-tests and execution-specs require coincurve and currently require >=17,<18.

We'd like to upgrade the required minimum major version of coincurve from 17 to 18 in order to get full Python 3.11 support (ethereum/execution-spec-tests#280). This simplifies installation of execution-test-specs on macOS cf ethereum/execution-spec-tests#274.

Before we can do that, we need execution-specs to upgrade first :-)

How was it fixed?

image

Cute Animal Picture

image
"Psst, plz upgrade to coincurve 18!"

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a592a8) 74.06% compared to head (198893e) 74.06%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files         571      571           
  Lines       31735    31735           
=======================================
  Hits        23503    23503           
  Misses       8232     8232           
Flag Coverage Δ
unittests 74.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petertdavies petertdavies merged commit fade6e9 into ethereum:master Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants