Add descriptions of to_mem and clone to spec. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
changed the title
cburgdorf
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Nice. I left some comments inline where I think we might be able to make it even clearer. Also, this could use a 195.doc.md file to go into the release notes (I will just regenerate the release notes in #194 which is why I put my manual edits into a second commit that I can just re-apply)
satyamakgec
approved these changes
Jan 19, 2021
g-r-a-n-t
force-pushed
the
spec-updates
branch
from
217828b
to
85825fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We were missing descriptions of these two builtin functions in the spec.
How was it fixed?
Added descriptions in the data layout section.
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history