MemoryBuffer, precompiles, raw_call #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
reviewed
May 11, 2023
g-r-a-n-t
commented
May 17, 2023
crates/library/std/src/buf.fe
Outdated
| } | ||
| } | ||
|
|
||
| // todo: fix compiler panic produced by this |
crates/library/std/src/buf.fe
Outdated
| return buf | ||
| } | ||
|
|
||
| // todo: fix compiler panic produced by this |
There was a problem hiding this comment.
report this if not a duplicate issue
|
|
||
| // todo: require no return value | ||
| #test | ||
| // todo: yulgen panic on `identity` |
cburgdorf
reviewed
May 18, 2023
g-r-a-n-t
force-pushed
the
precompiles
branch
3 times, most recently
from
df25226
to
a82226a
Compare
cburgdorf
approved these changes
May 22, 2023
| @@ -0,0 +1,15 @@ | |||
| pub fn min(_ x: u256, _ y: u256) -> u256 { | |||
There was a problem hiding this comment.
I just wanted to suggest that we could define an Ord trait and then have the min / max functions be generic and work with any T that is Ord but free floating functions such as these can not use generics yet as we only allow struct methods to be generic for now....so, nothing to see here.
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the following to the std lib:
ctx.raw_call(...)To-Do