Make duplicate function definitons a fatal error #455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 86.77% 86.90% +0.12%
==========================================
Files 70 70
Lines 4803 4804 +1
==========================================
+ Hits 4168 4175 +7
+ Misses 635 629 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good. I have some ideas about further reducing error fatalities that I might implement when the salsa stuff is in. Basically in this case the 'bar' function would be marked as "tainted", and only the use of 'bar' would be fatal. When (or if??) the analyzer is query-based, error fatality won't stop all analysis, just that of the current definition.
| 4 │ ╭ pub def bar: | ||
| 5 │ │ s | ||
| │ ╰──────^ Conflicting definition of contract `bar` |
There was a problem hiding this comment.
I guess "contract" is a copy-paste issue neither of us noticed last time. Probably worth fixing now.
When we have a duplicate function defintion it becomes unsafe to retrieve type information about such function because it can not be guaranteed whether we retrieve the type for function a or a'. Fixes ethereum#451
cburgdorf
force-pushed
the
christoph/fix/error-message-duplicate-def
branch
from
ec7e1a1
to
d897503
Compare
What was wrong?
#451 demonstrates an interesting issue where we crash when trying to present a certain error. The reason for that is that the function is defined multiple times and when we retrieve the type information for another error we don't get the type for that function
barthat we assume but for that otherfunctionbar that has a different type.How was it fixed?
An easy way to fix this is to say that duplicate definitions are treated as fatal errors with the reasoning that it becomes unsafe to retrieve type information for definitions of which we have multiple for the same name.