Fix SignTx calls in executables other than geth.

ethereum · Aug 24, 2017 · 214c4e1 · 214c4e1
1 parent 165e40b
commit 214c4e1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cmd/faucet/faucet.go b/cmd/faucet/faucet.go
@@ -446,7 +446,7 @@ func (f *faucet) apiHandler(conn *websocket.Conn) {
 			amount = new(big.Int).Div(amount, new(big.Int).Exp(big.NewInt(2), big.NewInt(int64(msg.Tier)), nil))
 
 			tx := types.NewTransaction(f.nonce+uint64(len(f.reqs)), address, amount, big.NewInt(21000), f.price, nil)
-			signed, err := f.keystore.SignTx(f.account, tx, f.config.ChainId)
+			signed, err := f.keystore.SignTx(f.account, tx, f.config.ChainId, false)
 			if err != nil {
 				websocket.JSON.Send(conn, map[string]string{"error": err.Error()})
 				f.lock.Unlock()

diff --git a/internal/guide/guide_test.go b/internal/guide/guide_test.go
@@ -85,7 +85,7 @@ func TestAccountManagement(t *testing.T) {
 	if err := ks.Unlock(signer, "Signer password"); err != nil {
 		t.Fatalf("Failed to unlock account: %v", err)
 	}
-	if _, err := ks.SignTx(signer, tx, chain); err != nil {
+	if _, err := ks.SignTx(signer, tx, chain, false); err != nil {
 		t.Fatalf("Failed to sign with unlocked account: %v", err)
 	}
 	if err := ks.Lock(signer.Address); err != nil {
@@ -95,7 +95,7 @@ func TestAccountManagement(t *testing.T) {
 	if err := ks.TimedUnlock(signer, "Signer password", time.Second); err != nil {
 		t.Fatalf("Failed to time unlock account: %v", err)
 	}
-	if _, err := ks.SignTx(signer, tx, chain); err != nil {
+	if _, err := ks.SignTx(signer, tx, chain, false); err != nil {
 		t.Fatalf("Failed to sign with time unlocked account: %v", err)
 	}
 }
diff --git a/mobile/accounts.go b/mobile/accounts.go
@@ -120,7 +120,7 @@ func (ks *KeyStore) SignTx(account *Account, tx *Transaction, chainID *BigInt) (
 	if chainID == nil { // Null passed from mobile app
 		chainID = new(BigInt)
 	}
-	signed, err := ks.keystore.SignTx(account.account, tx.tx, chainID.bigint)
+	signed, err := ks.keystore.SignTx(account.account, tx.tx, chainID.bigint, false)
 	if err != nil {
 		return nil, err
 	}