miner: fail early if core.NewBlockChain fails (#26079)

don't ignore errors returned by core.NewBlockChain when initializing tests
ethereum · Nov 2, 2022 · 24f08ec · 24f08ec
1 parent a2a144c
commit 24f08ec
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/miner/worker_test.go b/miner/worker_test.go
@@ -134,7 +134,10 @@ func newTestWorkerBackend(t *testing.T, chainConfig *params.ChainConfig, engine
 	default:
 		t.Fatalf("unexpected consensus engine type: %T", engine)
 	}
-	chain, _ := core.NewBlockChain(db, &core.CacheConfig{TrieDirtyDisabled: true}, gspec, nil, engine, vm.Config{}, nil, nil)
+	chain, err := core.NewBlockChain(db, &core.CacheConfig{TrieDirtyDisabled: true}, gspec, nil, engine, vm.Config{}, nil, nil)
+	if err != nil {
+		t.Fatalf("core.NewBlockChain failed: %v", err)
+	}
 	txpool := txpool.NewTxPool(testTxPoolConfig, chainConfig, chain)
 
 	// Generate a small n-block chain and an uncle block for it