Skip to content

Commit

Permalink
accounts/usbwallet/trezor: expose protobuf package (#17980)
Browse files Browse the repository at this point in the history
When some of the same messages are redefined anywhere in a Go project,
the protobuf package panics (see
golang/protobuf#178).

Since this package is internal, there is no way to work around it, as
one cannot use it directly, but also cannot define the same messages.

There is no downside in making the package accessible.
  • Loading branch information
benma authored and fjl committed Jan 26, 2019
1 parent 2209fed commit dddd6ef
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion accounts/usbwallet/trezor.go
Expand Up @@ -28,7 +28,7 @@ import (
"math/big"

"github.com/ethereum/go-ethereum/accounts"
"github.com/ethereum/go-ethereum/accounts/usbwallet/internal/trezor"
"github.com/ethereum/go-ethereum/accounts/usbwallet/trezor"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/hexutil"
"github.com/ethereum/go-ethereum/core/types"
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit dddd6ef

Please sign in to comment.