Use different default port for RPC #186
Comments
tgerring
added a commit
to tgerring/go-ethereum
that referenced
this issue
Feb 4, 2015
|
Default port is now 8545 with change merged into develop branch. |
AusIV
pushed a commit
to NoteGio/go-ethereum
that referenced
this issue
Nov 12, 2020
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this issue
Aug 13, 2021
* gaslimit: fix eth_call * test: fix build
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this issue
Jan 20, 2022
* Allow Istanbul to have future blocks too * Fix types * Get failing test to pass * Fix segfault * Reorganize and get tests to actually pass * Go lint
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this issue
Feb 23, 2023
revert tx trace struct
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this issue
Aug 1, 2023
Allow pruning to multiple targets, including without snapshots
atenjin
pushed a commit
to alt-research/go-ethereum
that referenced
this issue
Apr 4, 2024
…oad) (ethereum#186) * miner: Add block building interruption on payload resolution (getPayload) * miner: Change full payload resolution, fix and add test * miner: Add parameter validation if skipping empty block We only build the empty block if we don't use the tx pool. So if we use the tx pool, a forkchoiceUpdated call would miss the implicit validation that's happening during empty block building, so we need to add it back. * miner: Always wait for block builder result after interrupting This commit changes the way the block builder/update routine and the resolution functions Resolve and ResolveFull synchronize. Resolve(Full) now signal the payload builder to pause and set the interrupt signal in case any block building is ongoing. They then wait for the interrupted block building to complete. This allowed to simplify the Payload implementation somewhat because the builder routine is now guaranteed to return before the resulting fields (full, fullFees etc) are read, and closing of the `stop` channel is now synchronized with a sync.Once. So the mutex and conditional variable could be removed and we only use two simple signalling channels `stop` and `done` for synchronization. * miner: Add testing mode to module Some test in the miner and catalyst package assume that getPayload can be immediately called after forkchoiceUpdated and then to return some built block. Because of the new behavior of payload resolution to interrupt any ongoing payload building process, this creates a race condition on block building. The new testing mode, which can be enabled by setting the package variable IsPayloadBuildingTest to true, guarantees that always at least one full block is built. It's hacky, but seems to be the easiest and less-intrusive way to enable the new behavior of payload resolution while still keeping all tests happy. * miner: Further improve block building interruption - Priotize stop signal over recommit - Don't start payload building update if last update duration doesn't fit until slot timeout. * miner: Partially revert rework of payload build stopping When resolving, we don't want to wait for the latest update. If a full block is available, we just return that one, as before. Payload building is still interrupted, but exits in the background. * miner: Return early when building interrupted payload updates * Remove global variable to change miner behaviour. Use a longer wait in tests for the payload to build. * miner: Interrupt first payload building job Also added interrupt test. Had to add sleep to make non-interrupt test work. * eth/catalyst: Add even more sleeps to make tests get over payload interruption * Deterministically wait for payloads to build the first full block * eth/catalyst,miner: Improve payload full block waiting in tests Also fix a bug in TestNilWithdrawals where the withdrawals weren't added to the ephemeral BuildPayloadArgs instance for re-calculating the payload id. * miner: Calculate sane block building time in validateParams Also always stop interrupt timer after fillTransactions in generateWork. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, RPC defaults to port 8080, which is a widely used port for alternate/non-root web servers.
Ethereum should choose a different port as the default.
some relevant examples:
bitcoind - 8332
btcd - 8334
namecoin - 8336
bitmessage - 8444
The text was updated successfully, but these errors were encountered: