Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: eth.sign should return the ethereum canonical version of the signature #2053

Closed
obscuren opened this issue Dec 5, 2015 · 9 comments
Closed

RPC: eth.sign should return the ethereum canonical version of the signature #2053

obscuren opened this issue Dec 5, 2015 · 9 comments
Labels
area:rpc type:bug

Comments

@obscuren
Copy link
Contributor

obscuren commented Dec 5, 2015

Ethereum defines the V param as V + 27 (Py relic)
@tgerring
Copy link
Contributor

tgerring commented Jan 8, 2016

Will this be included with the 1.4.0 milestone?

@MrChico MrChico mentioned this issue Mar 2, 2016
Closed
@MrChico MrChico mentioned this issue Mar 17, 2016
Closed
@kumavis
Copy link
Member

kumavis commented Jul 12, 2016

👍 plz 👍

This was referenced Jul 12, 2016
Merged
Closed
@axic
Copy link
Member

axic commented Aug 24, 2016

Can we get this discrepancy fixed in the future (soon-ish)? Many tools actually support both [0, 1] and [27, 28] so the impact should be limited. The longer this "fix" waits, the bigger the impact will be.

@fjl
Copy link
Contributor

fjl commented Aug 24, 2016

The next chance to fix it is #2940

@fjl
Copy link
Contributor

fjl commented Aug 24, 2016

Please leave any suggestions for improving eth_sign there.

@charles-cooper charles-cooper mentioned this issue Jun 5, 2017
Closed
@3esmit
Copy link

3esmit commented Sep 25, 2017

this was fixed?

@Moejoe90
Copy link

What's the update on this?

@Firescar96
Copy link
Contributor

I think you can close this now, it's been resolved.

@adamschmideg adamschmideg added area:rpc and removed RPC labels Dec 14, 2018
@fjl fjl closed this as completed Mar 5, 2019
@fleupold fleupold mentioned this issue May 26, 2020
Merged
@ducthotran2010 ducthotran2010 mentioned this issue Sep 24, 2020
Closed
@alexeyneu
Copy link

yeah it's been resolved but we still have +27 haha
https://github.com/bitbill/bitbill-multisig-contracts/blob/f79bf0ad58990b80cc584786044c140a44adbe73/OwnbitMultiSigV4.sol#L168

@fedgiac fedgiac mentioned this issue Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@fjl @axic @adamschmideg @3esmit @tgerring @kumavis @Firescar96 @obscuren @Moejoe90 @alexeyneu