Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mist error handling if import of JS file fails #279

Closed
Gustav-Simonsson opened this issue Jan 30, 2015 · 0 comments
Closed

Improve mist error handling if import of JS file fails #279

Gustav-Simonsson opened this issue Jan 30, 2015 · 0 comments

Comments

@Gustav-Simonsson
Copy link

If a non-JS file is imported in Mist, it can cause Mist to hang.

From bug report:

"It never checks if it is a js file. When it is run in the Otto VM, it is not checking for errors as well. It should either check before trying evaluate it or when running it in the otto vm?

https://github.com/ethereum/go-ethereum/blob/develop/javascript/javascript_runtime.go#L34

@fjl fjl closed this as completed Jun 23, 2015
nonsense added a commit that referenced this issue Mar 23, 2018
prestonvanloon added a commit to prestonvanloon/go-ethereum that referenced this issue Jul 15, 2018
ngtuna added a commit to ngtuna/tomochain that referenced this issue Nov 16, 2018
Zergity added a commit to Zergity/go-ethereum that referenced this issue Apr 28, 2020
AusIV pushed a commit to NoteGio/go-ethereum that referenced this issue Feb 22, 2021
ethereum#279)

Use datadir migration logic to rename directory if exists.
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Aug 13, 2021
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue May 3, 2022
* Fix protobuf file

* Small fix

* Use grpc streams to send big debug files
weiihann pushed a commit to weiihann/go-ethereum that referenced this issue Nov 30, 2023
activate proof generation on fork  + remove code dups

use go-verkle's post-state API to verify proofs (ethereum#262)

use prague as the verkle activation fork (ethereum#263)

upgrade to latest go-ipa

activate verkle transition in "miner" (ethereum#265)

fix: do not force cancunTime upon verkle activation

workaround: do not use root translation in replay

workaround: deactivate overlay transition for now

fixes from trying to get the devnet to work (ethereum#267)

this line was left out from the previous commit

upgrade to go-verkle with fixed newvalue serialization

fix: ensure point cache isn't nil in copy (ethereum#268)

fix: dependency cycle in tests (ethereum#269)

upgrade to latest go-verkle

fix: write trie preimage data to db (ethereum#274)

fix: zero-root in produced block + sync (ethereum#275)

upgrade go-ipa

fix build

fix typo

include review feedback

add switch to add proofs to blocks (ethereum#278)

add fee recipient to witness (ethereum#279)

touch all fields in withdrawal account header (ethereum#277)
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this issue Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants