-
Notifications
You must be signed in to change notification settings - Fork 19.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the UI of top bar on Mist #441
Comments
This is being worked on in the PR: #450 It has the current issues: Close, minimize, maximize (zoom/fullscreen on mac) buttons are non-functional. From research it seems that while QML supports Qt.quit() and Qt.showMinimized() commands, those must be enabled by the lower level window object. Resize windows is choppy and often causes the main window to lose it’s shadow effect. This might need some lower level access to the window object. The current resize method simply changes the x, y, width and height of the root qml object, there might be more optimised ways to do it. In QML there is no way to find out the platform in order to change elements. This is needed because the position of the close/minimize/maximize buttons need to change according to the platform. Currently all buttons are left aligned, like on the mac, but this should be right aligned on windows and most linux distress (ubuntu being an exception). |
build: increase deadline for linter
testnet: add hard-fork block, allow nodes to sign block
Release/v1.12.4
* contract_comm/currency/currency.go * fixed the txn price-sorted min-heap * merge master (ethereum#490) * Add precompiles to access validator set (ethereum#441) * set max gas to double of the charged gas for the 'intrinsic' smart contract calls (ethereum#472) * set max gas to double of the charged gas for the 'intrinsic' evm operations * addressed PR comments * addressed pr comment * Adds Prepared Certificates to ensure Istanbul liveness (ethereum#366) * Check message address against signature (ethereum#477) * Check signing validator's address matches msg address * Add comments about use of sig data in tests * Try fix Circle build test failures * Try fix Circle build test failures, take 2
* Log on ValidatorElections * merge master (ethereum#496) * Check message address against signature (ethereum#477) * Check signing validator's address matches msg address * Add comments about use of sig data in tests * Try fix Circle build test failures * Try fix Circle build test failures, take 2 * tx price heap fix (ethereum#471) * contract_comm/currency/currency.go * fixed the txn price-sorted min-heap * merge master (ethereum#490) * Add precompiles to access validator set (ethereum#441) * set max gas to double of the charged gas for the 'intrinsic' smart contract calls (ethereum#472) * set max gas to double of the charged gas for the 'intrinsic' evm operations * addressed PR comments * addressed pr comment * Adds Prepared Certificates to ensure Istanbul liveness (ethereum#366) * Check message address against signature (ethereum#477) * Check signing validator's address matches msg address * Add comments about use of sig data in tests * Try fix Circle build test failures * Try fix Circle build test failures, take 2 * added new option --use-in-memory-discovery-table (ethereum#479) * added new option --use-in-memory-discovery-table * merge master (ethereum#489) * Adds Prepared Certificates to ensure Istanbul liveness (ethereum#366) * Check message address against signature (ethereum#477) * Check signing validator's address matches msg address * Add comments about use of sig data in tests * Try fix Circle build test failures * Try fix Circle build test failures, take 2 * Allow v4/v5 on a bootnode simultaneously, allow mobile to use discv5 (ethereum#454) * changes for isolating celo networks * changes to get unit tests working * changes to add salt in the discovery packets * removed checking for the ip address when handling a reply * added ping-ip-from-packet option to bootnode * for handling expected replies, don't filter on expected sender ip address if --pingIPFromPacket is used * Add v4 flag * Add unhandled and quicken docker builds * Add salt & logs * Add v4 flag * Add PeerDiscovery to mobile node config * Remove logs * Remove hardcoded bootnodes * Add salt & turn on discv5 * Delete hardcoded eth bootnodes * Make Discoveryv5 configurable * Lint * Add comment to bootnode v4/v5 handling * Change PeerDiscovery -> NoDiscovery * Remove mobile geth no discovery * Reduce istanbul default timeout, cap exp backoff (ethereum#475) * Reduce istanbul default timeout, cap exp backoff * Ensure round 0 timeout factors in block period * Sanitize logs (ethereum#495) * Change registry lookup and infrastructure lookup error logs to debug level * Sanitize logs regarding registry deployment * Change empty abi logging and comment * Lower log level from error to warning for potentially outdated istanbul messages * Change back to an error message * Add input length checks for precompiled contracts (ethereum#476) * add input length checks * check exact input length. add a new error for input length. check input in a few more places * add tests that verify the input-length checks for contracts that don't require an evm instance * fix formatting * add comments to explain input length checks * run the formatter * e2e transfer test was failing because it passes in a transaction options object, making the input larger than 96 bytes * e2e tests have revealed that our precompiled contracts need to be tolerant of inputs that are longer than the bytes that are actually read
…thereum#441) * fix(t8n/exec): Small change to fix filling. * cmd/evm/main: Add witness t8ntool flag.
Currently the mist UI uses a default native top bar that interferes with the current proposed design and it looks out of place.
The text was updated successfully, but these errors were encountered: