crypto/sha3: pull in latest keccak from go crypto (45% speed increase) #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obscuren @Gustav-Simonsson Please check this to make sure I didn't screw up something bad :D |
|
@karalabe Since all Ethereum system tests (BlockTests, TransactionTests) etc pass it should be fine. They contain a ton of different values and so unique hashes which are all verified for equality, so it's extremely unlikely this change broke something 👍 |
obscuren
added a commit
that referenced
this pull request
Jun 3, 2015
crypto/sha3: pull in latest keccak from go crypto (45% speed increase)
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced our keccak implementation with the official Go version, which gained about 45% increase on the benchmarks on my Core2 laptop. To keep the code a bit cleaner, I've copied the official go keccac file (https://github.com/golang/crypto/blob/master/sha3/keccakf.go) as is into our own repo, and called that function directly from our sha3 instead of the previous
d.keccakwrapper (i.e. to keep the keccak go file updatable to new versions if need be).