cmd/puppeth: your Ethereum private network manager #13854
Conversation
karalabe
commented
Mar 30, 2017
•
karalabe
commented
|
@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obscuren, @zsfelfoldi and @Gustav-Simonsson to be potential reviewers. |
karalabe
force-pushed
the
puppeth
branch
5 times, most recently
from
9af9471
to
cdc35e1
Compare
| continue | ||
| } | ||
| if gist.Owner.Login == "" { | ||
| websocket.JSON.Send(conn, map[string]string{"error": "Nice try ;)"}) |
There was a problem hiding this comment.
It's usually best to split up code into functions so the handling of the error can be done once. If you move handling of gists and their content into a function, you could remove most of the
websocket.JSON.Send(conn, map[string]string{"error": "..."})
continue
cmd/faucet/faucet.go
Outdated
| websocket.JSON.Send(conn, map[string]string{"error": "URL doesn't link to GitHub Gists"}) | ||
| continue | ||
| } | ||
| log.Info("Faucet funs requested", "gist", msg.URL) |
cmd/faucet/faucet.html
Outdated
| </div> | ||
| <div class="row"> | ||
| <div class="col-lg-8 col-lg-offset-2"> | ||
| <div class="input-group"> |
There was a problem hiding this comment.
HTML indentation is totally nuts here. Maybe use a formatter.
|
@fjl PTAL. I fixed the typo and the indentation. I did not have time tonight to address the error handling. Please consider whether you can live with the current code, and if not, I'll try to address it tomorrow. |
|
I can live with almost anything, including this PR. |
