eth: announce block after sync cycle (star topology) #13883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fjl, @obscuren and @zsfelfoldi to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2995
When completing a sync cycle, notify all peers of new state. This path is essential in star-topology networks where a gateway node needs to notify all its out-of-date peers of the availability of a new block, which it currently does not do.
This failure scenario will most often crop up in private and hackathon networks with degenerate connectivity, but it should be healthy for the mainnet too to more reliably update peers or the local TD state.