les: allow LES connection to other servers #13889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsfelfoldi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karalabe and @fjl to be potential reviewers. |
|
Do servers ever push data to clients without them requesting? E.g. new blocks. What happens if servers receive these pushes? Because they will do so after this pr |
evanstapler
approved these changes
Apr 10, 2017
|
They will send new block announcements to each other and ignore incoming ones, nothing else will happen. Since this is only a temporary workaround until we have a proper solution, I did not want to risk breaking things by adding more conditions. |
fjl
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately at the moment we have to either run LES protocol with every LES capable peer (even if it is useless) or drop them. So until we have a proper peer connectivity API which allows connecting through ETH but not through LES, allow LES connection to other servers.
This is a fix for #13877