cmd/faucet, cmd/puppeth: support multi-tiered faucet #14402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
May 4, 2017
cmd/faucet/faucet.go
Outdated
| period /= 60 | ||
| periods[i] = fmt.Sprintf("%d hours", period) | ||
| } | ||
| if period%24 == 0 { |
There was a problem hiding this comment.
I don't follow.. So period is expressed in minutes. So what if it's set to 24 minutes - divisable by 24 but not by 60 ? Don't you need to always divide by 60, not just when it's divisable by 60 ?
There was a problem hiding this comment.
I added this last minute since until now we didn't care about days. Fil fix in a moment.
There was a problem hiding this comment.
Pushed a commit to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different people have different work styles. Some like to request faucet funds more frequently, some want a big batch that they can then spend without worrying about more. This PR adds a tiered feature to the faucet that supports retrieving bigger amounts of funds in exchange for longer request timeout.
There is a slight preference towards more frequent requests via a funding penalty on large amounts.