eth/downloader: don't process trie nodes on the queue thread #14449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
fix-downloader-lockup
branch
from
b6eec4d
to
7a4d359
Compare
This was referenced May 9, 2017
Closed
karalabe
force-pushed
the
fix-downloader-lockup
branch
from
7a4d359
to
4ba7ace
Compare
karalabe
force-pushed
the
fix-downloader-lockup
branch
from
4ba7ace
to
dbb742e
Compare
|
This will be superseeded by #14460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a downloader regression introduced in f1069a3 which placed trie node processing into the downloader thread (opposed to running in a dedicated thread as before). On an HDD machine, that process method call alone can take up to 50s when the database grows and a compaction is running. This caused all pending state retrievals to time out (since the goroutine accepting them was actually busy importing stuff). Hard timeouts caused peers drops, which made fast sync impossible on HDD.
Edit: this doesn't solve it yet, as the lock prevents the downloader from requesting new states to download, causing the same slowdown/staleness false positives.