ethstats: reduce ethstats traffic by trottling reports #14563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
reviewed
May 31, 2017
|
|
||
| for { | ||
| select { | ||
| // Notify of chain head events, but drop if too frequent |
There was a problem hiding this comment.
You don't actually drop if too frequent here.
There was a problem hiding this comment.
It does drop in
select {
case headCh <- head.Data.(core.ChainHeadEvent).Block:
default:
}
If the channel already contains a head, then I'm not waiting to add another one.
The reason I've added an additional 1sec throttling for txs is because the payload is tiny, so when a lot of txs are added, still a lot of requests manage to slip through to ethstats.
Arachnid
approved these changes
Jun 1, 2017
obscuren
approved these changes
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ethstats package a bit to throttle transaction reports to once per second max and chain head reports too. This should help lessen the load from ethstats if it's being overwhelmed.