accounts/keystore, crypto: don't enforce key checks on existing keyfiles #14565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
relax-privkey-checks
branch
from
04beacd
to
171e943
Compare
obscuren
approved these changes
Jun 1, 2017
karalabe
force-pushed
the
relax-privkey-checks
branch
from
171e943
to
72dd51e
Compare
Arachnid
approved these changes
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #14502 PR turned out to be a bit overzealous. It enforced all private keys to be 256 bits. Although it makes sense, apparently there are some very old keyfiles lingering here and there that were encoded badly and thus fail to decode with the size enforcement.
This PR changes the logic so that enforcement is only done when creating new keys, but if a keyfile contains something weird already, it will still accept it.