New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txpool localaccounts #14737

merged 7 commits into from Jul 10, 2017


None yet
3 participants

holiman commented Jun 30, 2017

This pr can be considered a PoC for maintaining locals-map based on sender accounts instead of tx hashes. Notably:

  • It does not 'cache', it's a never-cleared map. For extreme users, with hundreds of thousands of accounts, that may be problematic. Such users (like Mew/Infura) need an CLI option --no-locals , which is not implemented in this PR.
  • It has no new testcases, but the old ones seems at least not to be br0kken.

Also, the second commit contains two fixes where it seems to me that locals could incorrectly be dropped. I haven't backed that up with a testcase neither, but PTAL and even if this PR isn't merged, that commit may be a usefull cherry.

@holiman holiman requested a review from karalabe Jun 30, 2017

karalabe added some commits Jul 5, 2017

core: test locals support in txpool queue limits, fix
The commit reworks the transaction pool queue limitation tests
to cater for testing local accounts, also testing the nolocal flag.

In addition, it also fixes a panic if local transactions exceeded
the global queue allowance (no accounts left to drop from) and also
fixes queue eviction to operate on all accounts, not just the one
being updated.

@karalabe karalabe merged commit 4f7a380 into ethereum:master Jul 10, 2017

3 checks passed

commit-message-check/gitcop All commit messages are valid
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@karalabe karalabe added this to the 1.6.7 milestone Jul 10, 2017

@holiman holiman deleted the holiman:txpool_localaccounts branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment