rpc: to in eth_call no longer required. Fixed eth_estimateGas #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -932,15 +932,6 @@ func TestCallArgsNotStrings(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestCallArgsToEmpty(t *testing.T) { | |||
There was a problem hiding this comment.
This test could be left in by changing the check that from is populated correctly and to is nil
There was a problem hiding this comment.
Agreed. Will adjust
| if len(str) > 0 { | ||
| t.Error(str) | ||
| err := json.Unmarshal([]byte(input), &args) | ||
| if err != nil { |
There was a problem hiding this comment.
Not as precise as validating the field content, but in the case that we're only checking the requirement of "To" or not, this will suffice
|
👍 |
1 similar comment
|
👍 |
obscuren
added a commit
that referenced
this pull request
Jul 30, 2015
rpc: to in eth_call no longer required. Fixed eth_estimateGas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040