Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm, internal/ethapi: tracer no full storage, nicer json output #15499

Merged
merged 2 commits into from
Nov 16, 2017
Merged

core/vm, internal/ethapi: tracer no full storage, nicer json output #15499

merged 2 commits into from
Nov 16, 2017

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Nov 16, 2017 •
edited
Loading

This PR does a few tiny tracer polishes:

  • Drops support for fullStorage option. It's just insane to print the entire storage of a contract at every single executed opcode.
  • Omits the error:null output for each and every traced opcode.
  • Fixes the memory field of an opcode to not be null, rather [] if empty.
  • Any fields disabled in the tracer get omitted from the results.

Fixes #15480 too.

@karalabe karalabe added this to the 1.7.3 milestone Nov 16, 2017
@karalabe karalabe merged commit b019018 into ethereum:master Nov 16, 2017
@5chdn 5chdn mentioned this pull request Nov 27, 2017
Merged
@benjamincburns benjamincburns mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Arachnid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karalabe @Arachnid