internal/ethapi: avoid recreating JavaScript tracer wrappers #15552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During tracing, 26% of the time is currently spent in wrapping an opcode into a JavaScript object for otto. But there's no reason to wrap each opcode one by one, rather we can reuse the same JavaScript wrapper, just replace the opcode inside it.
The remainder of the PR is just removing some assignments to make the code a bit cleaner and more efficient, although I don't think there are to significant performance improvements there.