puppeth: Adding verbosity flag

[Swader]

This change solves issue #16905 by disabling log output when asking for enode address from a deployed node.

[GitCop]

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

• Commit: 6269132
• Your commit message body contains a line that is longer than 80 characters

Please check the contribution guidelines for more details.

---

This message was auto-generated by https://gitcop.com

[Swader]

@karalabe I think this is ripe for the maintenance release, could you review when you catch a breath please?

[karalabe]

Although this does fix the issue, I'm a bit reluctant to hack it in like this, since it can silently fail issues later.

A nicer approach would be to change client.Run, so it doesn't merge the stdout and stderr streams, rather returns them separately (https://github.com/ethereum/go-ethereum/blob/master/cmd/puppeth/ssh.go#L198). I know this is a bit larger change, but it would be a lot more robust.

[Swader]

I see. That's a bit outside my current comfort level with Go and Geth but I'll do my best to find some time and make it happen if someone doesn't beat me to it. The reason why I'm eager to get this fixed is because I'm writing a DAO course at SitePoint that's half done and there's a Puppeth tutorial pending too, all of which are blocked from publication because VM-based Puppeth-started PoA chains can't be deployed right now, and that's one of the routes we're demonstrating in the tutorials.

[karalabe]

This was fixed in the previous release.