Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: Log targetGasLimit at startup #17089

Closed
wants to merge 1 commit into from
Closed

cmd/utils: Log targetGasLimit at startup #17089

wants to merge 1 commit into from

Conversation

wbt
Copy link
Contributor

@wbt wbt commented Jun 26, 2018

Should produce log message like "Current effective targetGasLimit=1234567"
Still working on testing setup.

Should produce log message like "Current effective targetGasLimit=1234567"
@GitCop
Copy link

GitCop commented Jun 26, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: d36bfcc
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@wbt wbt changed the title Adding log statement for Geth Issue #17076 cmd/utils: Log targetGasLimit at startup Jun 26, 2018
@karalabe
Copy link
Member

We've merged in #17248 which should cover the original issue prompting this PR too. Now flag's won't silently be interpreted as commands and discarded. I think that's a better solution than individually trying to cover one or more flags.

@karalabe karalabe closed this Jul 26, 2018
@wbt
Copy link
Contributor Author

wbt commented Aug 21, 2018

I think this still could be a useful log message, both for people who don't understand that there is such an option and for people who use the option but keep geth running or store log files for long enough that they lack authoritative reference to the startup command used in that run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants