common/compiler: fix #1598, expose solidity errors

[karalabe]

This PR cleans up a bit the solidity compilation code + exposes the stderr stream of the solc compiler in case of a build error.

[robotally]

Vote	Count	Reviewers
👍	3	@bas-vk @fjl @zelig
👎	0

Reaction	Users
:1:	@bas-vk @karalabe

Updated: Wed Aug 26 17:38:30 UTC 2015

[karalabe]

@zelig PTAL

[fjl]

// Compilation succeeded, assemble and return the contracts.

Sentences. End. With. Period.

[karalabe]

I always use full sentences as variable, fumction, etc declarations. Within
the code, I never add the dots. It's a personal style :D
On Aug 25, 2015 10:55 PM, "Felix Lange" notifications@github.com wrote:

In common/compiler/solidity.go
#1717 (comment):

}

• contracts = make(map[string]*Contract)
• // Complilation succeeded, assemble and return the contracts

// Compilation succeeded, assemble and return the contracts.

Sentences. End. With. Period.

—
Reply to this email directly or view it on GitHub
https://github.com/ethereum/go-ethereum/pull/1717/files#r37911317.

[bas-vk]

typo Complilation -> Compilation

[karalabe]

Btw, if you look through the Go stdlib, they follow the same pattern (e.g. https://golang.org/src/math/sin.go?s=3697:3724#L191). All longer descriptions in front og public entities are full sentences, but internal "notes" are without a dot, so I'd like to keep to this.

Also it's a bit cleaner to me without a dot. The dot doesn't add any value to a few word comment, but both makes it longer as well as (for me) draws attention as a syntax element :P

[bas-vk]

The solc error doesn't seem to be parsed and displayed in the console.

> eth.compile.solidity("contract a{)")
Invalid JSON RPC response: undefined
    at InvalidResponse (<anonymous>:-81076:-37)
    at send (<anonymous>:-154580:-37)
    at solidity (<anonymous>:-131712:-37)
    at <anonymous>:1:1

It don't think it's related to this PR and might have something to do with #1709. I'm investigating this.

[karalabe]

@bas-vk @fjl Fixed the two typos. Still struggling wit the atom spell checker... it doesn't support looking inside comments only so it's very annoying... if you know a fix for this? :D

[karalabe]

@bas-vk Maybe these are separate issues. Running the embark framework on your invalid "file" results in:

Warning: solc: exit status 1
<stdin>:1:12: Parser error: Function, variable, struct or modifier declaration expected.
contract a{)
           ^
 Use --force to continue.

[bas-vk]

There is a bug in the console error handling/parsing. When an error contains specific characters the JSON.parse method fails. I'm not familiar with embark but I guess they are using the http interface and don't use the Jeth.err method. I will create a PR for that.

For this PR 👍

[fjl]

👍

[zelig]

👍 perfetto maestro