Skip to content

dashboard: append to the proper slice - #17266

Merged
karalabe merged 1 commit into
ethereum:masterfrom
cristaloleg:possible-bug-in-dashboard
Jul 30, 2018
Merged

dashboard: append to the proper slice#17266
karalabe merged 1 commit into
ethereum:masterfrom
cristaloleg:possible-bug-in-dashboard

Conversation

@cristaloleg

Copy link
Copy Markdown
Contributor

Suspicious work with slice was found by 'appendAssign' checker as a part of go-critic.

@cristaloleg cristaloleg changed the title dashboard: append to proper slice dashboard: append to the proper slice Jul 30, 2018

@karalabe karalabe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@karalabe karalabe modified the milestone: 1.8.13 Jul 30, 2018
@karalabe
karalabe merged commit 7b1aa64 into ethereum:master Jul 30, 2018
@cristaloleg
cristaloleg deleted the possible-bug-in-dashboard branch July 30, 2018 09:49
firmianavan pushed a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018
Comment thread dashboard/dashboard.go
sys.SystemCPU = append(sys.SystemCPU[1:], systemCPU)
sys.DiskRead = append(sys.DiskRead[1:], diskRead)
sys.DiskWrite = append(sys.DiskRead[1:], diskWrite)
sys.DiskWrite = append(sys.DiskWrite[1:], diskWrite)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be write

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants