eth: add debug_accountRange

[jwasinger]

WIP Adds a debug API method AccountRangeAt which returns all accounts in the state for a given block and transaction index.

[jwasinger]

Is there a way to overload this so that I can have the rpc method accept a string for block number (e.g. "latest")?

[fjl]

I have not looked at the code, but we should think about the naming of the method. Existing *At methods access properties of an account at a specific address. Maybe it should just be debug_accountRange.

[jwasinger]

CC @cdetrio @gballet @winsvega

[axic]

Existing *At methods access properties of an account at a specific address.

Hm, since it has a starting address, would something like accountRangeBetween or accountRangeFrom be better?

[jwasinger]

For cpp-eth the method is called debug_accountRangeAt. I think we can look at changing the naming there in order to get this method included in Geth. We are using this method for ewasm testnet integration with https://github.com/gobitfly/etherchain-light .

[jwasinger]

I added this because I couldn't see any existing way to get access to the trie from the statedb

[karalabe]

You can do statedb.Database().OpenTrie()

[jwasinger]

This also needs unit tests.

[axic]

Are you sure startAddr should not be of common.Address type?

[jwasinger]

I think you're right.

[winsvega]

If to remove At.
Then what about accountStorageAt?

[jwasinger]

Existing *At methods access properties of an account at a specific address.

Looks like it wouldn't have be renamed.

[jwasinger]

Okay, have made suggested changes from @axic and @fjl . Another thing that @cdetrio pointed out was that I needed to be looking up the account key in preimage database to get the account address instead of keccak256(account address).

[jwasinger]

I'm getting an error from this line:

> curl -X POST -H 'Content-Type: application/json' --data '{"jsonrpc":"2.0","method":"debug_accountRange","params":[0, 0, "0x0000000000000000000000000000000000000000", 20],"id":1}' localhost:8545

{"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"parent 0000000000000000000000000000000000000000000000000000000000000000 not found"}}

Not sure what I'm doing wrong here.

[gballet]

I had a very quick look, and it seems that the message comes from here:

        block := api.eth.blockchain.GetBlockByHash(blockHash)
        if block == nil {
                return nil, vm.Context{}, nil, fmt.Errorf("block %x not found", blockHash)
        }
        parent := api.eth.blockchain.GetBlock(block.ParentHash(), block.NumberU64()-1)
        if parent == nil {
                return nil, vm.Context{}, nil, fmt.Errorf("parent %x not found", block.ParentHash())
        }

it seems normal that block 0's parent will not be found. The GetBlock function uses both the hash and the block number to find the parent, and the block number will be invalid.

[holiman]

On mobile here, so apologies for brevity... We usually use a blocknumOrHash type for specifying blocks, which also accept e.g the string 'latest'. Also, any use of this on mainchain will go OOM pretty quickly, unless a subscription is used instead of a full json dump. Perhaps a default limit should be used; so one doesn't accidentally OOM a node just by checking out "oh I wonder how this method works..."

[axic]

Perhaps a default limit should be used; so one doesn't accidentally OOM a node just by checking out "oh I wonder how this method works..."

Sounds good. Also the debug namespace must be turned on explicitly, correct? So this will not pose a main risk to a regular client.

[cdetrio]

I have not looked at the code, but we should think about the naming of the method. Existing *At methods access properties of an account at a specific address. Maybe it should just be debug_accountRange

I thought the At in debug_storageRangeAt referred to the starting key in the range. But I'm fine with just debug_accountRange.

[jwasinger]

blocknumOrHash

@holiman I looked through the codebase but couldn't find this type. Tried variations of capitalization as well.

[holiman]

See

go-ethereum/rpc/types.go

Line 133 in 5d30be4

func (bn *BlockNumber) UnmarshalJSON(data []byte) error {

Usage:

go-ethereum/eth/api_backend.go

Line 60 in 21c059b

func (b *EthAPIBackend) HeaderByNumber(ctx context.Context, blockNr rpc.BlockNumber) (*types.Header, error) {

blockNr rpc.BlockNumber

[GitCop]

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

• Commit: 4d090fc

• Commits must be prefixed with the package(s) they modify

• Commit: a6ca2cb

• Commits must be prefixed with the package(s) they modify

• Commit: 6bfaed3

• Commits must be prefixed with the package(s) they modify

• Commit: 46cf98d

• Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

---

This message was auto-generated by https://gitcop.com

[GitCop]

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

• Commit: 4d090fc

• Commits must be prefixed with the package(s) they modify

• Commit: a6ca2cb

• Commits must be prefixed with the package(s) they modify

• Commit: 6bfaed3

• Commits must be prefixed with the package(s) they modify

• Commit: 46cf98d

• Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

---

This message was auto-generated by https://gitcop.com

[axic]

Updated this to be compatible with aleth/testeth.

[gballet]

I have made the requested changes, added some unit tests and made sure that the call could be invoked with a nil pointer made sure that it worked with empty results.

[fjl]

@gballet not sure why you renamed this to "rpc: ...". The main change is in package "eth", the commit message prefix "eth" is appropriate.

[gballet]

the feature was an RPC call, seems logical enough to me.