Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/usbwallet: full 32bit chainId support for Trezor #17439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

accounts/usbwallet: full 32bit chainId support for Trezor #17439

wants to merge 1 commit into from

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Aug 18, 2018 •
edited

This fix allows Trezor to support full 32bit chainId in geth, with the next version of firmware.

For chainId > 2147483630 case, Trezor returns signature bit only.

  • Trezor returns only signature parity for chainId > 2147483630 case.
  • for chainId == 2147483630 case, Trezor returns MAX_UINT32 or 0, but it doesn't matter.
    (2147483630 * 2 + 35 = 4294967295(MAX_UINT32))
chainId returned signature_v compatible issue
0 < chainId <= 255 chainId * 2 + 35 + v no issue (firmware 1.6.2 for Trezor one)
255 < chainId <= 2147483630 chainId * 2 + 35 + v fixed. firmware 1.6.3
chainId > 2147483630 v firmware 1.6.3

Please see also: full 32bit chainId support for Trezor

@hackmod hackmod requested a review from karalabe as a code owner August 18, 2018 02:52
@hackmod hackmod force-pushed the trezor-32bit-chainid branch 2 times, most recently from d980c0d to 1679ca6 Compare August 28, 2018 12:27
@hackmod
Copy link
Contributor Author

hackmod commented Aug 28, 2018 •
edited

@hackmod hackmod force-pushed the trezor-32bit-chainid branch 2 times, most recently from 5092989 to 3d66ecd Compare September 6, 2018 07:17
@adamschmideg adamschmideg modified the milestones: 1.9.1, Backlog Jun 20, 2019
@fjl fjl changed the title full 32bit chainId support for Trezor accounts/usbwallet: full 32bit chainId support for Trezor Dec 8, 2020
@gballet gballet self-assigned this Dec 8, 2020
@fjl fjl removed the status:triage label Dec 8, 2020
@karalabe karalabe removed this from the Backlog milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@gballet gballet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hackmod @fjl @ligi @karalabe @adamschmideg @gballet @MariusVanDerWijden