-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: remove Go 1.9 #17807
Merged
Merged
travis: remove Go 1.9 #17807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lgtm
…On Tue, Oct 2, 2018, 11:54 Anton Evangelatov ***@***.***> wrote:
@nonsense <https://github.com/nonsense> requested your review on:
ethereum/go-ethereum#17807
<#17807> travis: remove Go
1.9.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#17807 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAH6GYdYRlpEcRln-318ClNBVLvaBgvoks5ugymvgaJpZM4XDmNE>
.
|
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Oct 9, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 6, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 8, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 11, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 12, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 12, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
nizsheanez
added a commit
to nizsheanez/go-ethereum
that referenced
this pull request
Nov 13, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
zelig
pushed a commit
that referenced
this pull request
Nov 14, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation (#18083) - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see #17807 and comments to swarm/network_test.go.Shuffle)
yazzaoui
pushed a commit
to autonity/autonity
that referenced
this pull request
Dec 6, 2018
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation (#18083) - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum/go-ethereum#17807 and comments to swarm/network_test.go.Shuffle)
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation (ethereum#18083) - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum#17807 and comments to swarm/network_test.go.Shuffle)
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation (ethereum#18083) - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum#17807 and comments to swarm/network_test.go.Shuffle)
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
cryptomental
pushed a commit
to cryptomental/go-ethereum
that referenced
this pull request
Jan 9, 2019
…m, swarm/storage, swarm/storage/encryption, swarm/testutil: use pseudo-random instead of crypto-random for test files content generation (ethereum#18083) - Replace "crypto/rand" to "math/rand" for files content generation - Remove swarm/network_test.go.Shuffle and swarm/btm/btm_test.go.Shuffle - because go1.9 support dropped (see ethereum#17807 and comments to swarm/network_test.go.Shuffle)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.9 won't contain any more security updates (if any are released), because Go 1.11 is released.
I think there is not much point keeping the Go 1.9 build anymore, since we have Go 1.10 and Go 1.11, furthermore we are putting additional load on Travis.